Get rid of Image::Image(SkBitmap*)

ui/gfx/image/image_unittest_util.h

Index: ui/gfx/image/image_unittest_util.h
diff --git a/ui/gfx/image/image_unittest_util.h b/ui/gfx/image/image_unittest_util.h
index fb471b9a3c0806eb5d95ab49452a90c3e124270c..6be1eaff2010adafdd75b651e5330392ad4aed20 100644
--- a/ui/gfx/image/image_unittest_util.h
+++ b/ui/gfx/image/image_unittest_util.h
@@ -18,10 +18,10 @@ typedef NSImage* PlatformImage;
 #elif defined(TOOLKIT_GTK)
 typedef GdkPixbuf* PlatformImage;
 #else
-typedef const SkBitmap* PlatformImage;
+typedef const SkBitmap PlatformImage;

[sky, 2012/05/09 14:24:03]

You sure you want this const?

 #endif
 
-SkBitmap* CreateBitmap(int width, int height);
+const SkBitmap CreateBitmap(int width, int height);
 
 gfx::Image CreateImage();
 
@@ -35,6 +35,11 @@ gfx::Image::RepresentationType GetPlatformRepresentationType();
 
 PlatformImage ToPlatformType(const gfx::Image& image);
 
+// Gets the platform representation and returns true if it is valid.

[sky, 2012/05/09 14:24:03]

How about just: Returns true if the platform representation is valid.

[pkotwicz, 2012/05/10 21:56:07]

This function is often used in unittests to generate a platform representation
for an image. Like below. Not sure if I am being explicit enough

EXPECT_EQ(1, image.RepresentationCount());
EXPECT_TRUE(gt::PlatformRepresentationIsValid(image));
EXPECT_EQ(2, image.RepresentationCount());

+bool PlatformRepresentationIsValid(const gfx::Image& image);
+
+bool PlatformImagesEqual(PlatformImage image1, PlatformImage image2);
+
 }  // namespace test
 }  // namespace gfx