Get rid of Image::Image(SkBitmap*)

ui/gfx/image/image_unittest_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Because the unit tests for gfx::Image are spread across multiple
 // implementation files, this header contains the reusable components.
 
 #ifndef UI_GFX_IMAGE_IMAGE_UNITTEST_UTIL_H_
 #define UI_GFX_IMAGE_IMAGE_UNITTEST_UTIL_H_
 
 #include "ui/gfx/image/image.h"
 
 namespace gfx {
 namespace test {
 
 #if defined(OS_MACOSX)
 typedef NSImage* PlatformImage;
 #elif defined(TOOLKIT_GTK)
 typedef GdkPixbuf* PlatformImage;
 #else
-typedef const SkBitmap* PlatformImage;
+typedef const SkBitmap PlatformImage;

[sky, 2012/05/09 14:24:03]

You sure you want this const?

 #endif
 
-SkBitmap* CreateBitmap(int width, int height);
+const SkBitmap CreateBitmap(int width, int height);
 
 gfx::Image CreateImage();
 
 bool IsEqual(const gfx::Image& image1, const gfx::Image& image2);
 
 bool IsEmpty(const gfx::Image& image);
 
 PlatformImage CreatePlatformImage();
 
 gfx::Image::RepresentationType GetPlatformRepresentationType();
 
 PlatformImage ToPlatformType(const gfx::Image& image);
 
+// Gets the platform representation and returns true if it is valid.

[sky, 2012/05/09 14:24:03]

How about just: Returns true if the platform representation is valid.

[pkotwicz, 2012/05/10 21:56:07]

This function is often used in unittests to generate a platform representation
for an image. Like below. Not sure if I am being explicit enough

EXPECT_EQ(1, image.RepresentationCount());
EXPECT_TRUE(gt::PlatformRepresentationIsValid(image));
EXPECT_EQ(2, image.RepresentationCount());

+bool PlatformRepresentationIsValid(const gfx::Image& image);
+
+bool PlatformImagesEqual(PlatformImage image1, PlatformImage image2);
+
 }  // namespace test
 }  // namespace gfx
 
 #endif  // UI_GFX_IMAGE_IMAGE_UNITTEST_UTIL_H_