Add a hash code to client and server web socket connections

Add a hash code to client and server web socket connections

The client web socket connection uses part of the nonce generated for
the challenge. The server web socket connection uses the hash code
from the socket.

R=ager@google.com

BUG=dart:3017
TEST=tests/standalone/io/web_socket_test.dart

Committed: https://code.google.com/p/dart/source/detail?r=7613

[Mads Ager (google), 2012-05-14 09:19:39]

lgtm

https://chromiumcodereview.appspot.com/10377124/diff/1/runtime/bin/websocket_...
File runtime/bin/websocket_impl.dart (right):

https://chromiumcodereview.appspot.com/10377124/diff/1/runtime/bin/websocket_...
runtime/bin/websocket_impl.dart:643: // Generate the nonce now as it is also
used to set the hash code.
I don't actually know if it would be a security issue to use the nonce in the
hash code. It does sound a little fishy, so maybe we should just generate some
more random bytes for the hash?

https://chromiumcodereview.appspot.com/10377124/diff/1/tests/standalone/io/we...
File tests/standalone/io/web_socket_test.dart (right):

https://chromiumcodereview.appspot.com/10377124/diff/1/tests/standalone/io/we...
tests/standalone/io/web_socket_test.dart:153: void testHashCode() {
How about extending this with a case where you put them in a hash map and find
them again?

[Søren Gjesse, 2012-05-14 15:52:41]

http://codereview.chromium.org/10377124/diff/1/runtime/bin/websocket_impl.dart
File runtime/bin/websocket_impl.dart (right):

http://codereview.chromium.org/10377124/diff/1/runtime/bin/websocket_impl.dar...
runtime/bin/websocket_impl.dart:643: // Generate the nonce now as it is also
used to set the hash code.
On 2012/05/14 09:19:39, Mads Ager wrote:
> I don't actually know if it would be a security issue to use the nonce in the
> hash code. It does sound a little fishy, so maybe we should just generate some
> more random bytes for the hash?

Done.

http://codereview.chromium.org/10377124/diff/1/tests/standalone/io/web_socket...
File tests/standalone/io/web_socket_test.dart (right):

http://codereview.chromium.org/10377124/diff/1/tests/standalone/io/web_socket...
tests/standalone/io/web_socket_test.dart:153: void testHashCode() {
On 2012/05/14 09:19:39, Mads Ager wrote:
> How about extending this with a case where you put them in a hash map and find
> them again?

Done.