Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 10376004: Instead of marking all default apps as bookmark apps, allow it to be specified per-app. (Closed)

Created:
8 years, 7 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Instead of marking all default apps as bookmark apps, allow it to be specified per-app. Controlled via the "is_bookmark_app" property in the external extensions JSON file. Removes the bookmark app option from GMail, since it uses the "notifications" permission, thus isn't just a bookmark. Also removes workaround for bug http://crbug.com/109791 (where we would reset the FROM_BOOKMARK flag even if it wasn't present anymore), since it's been out for a few releases, so no more users should need it. BUG=126042 R=asargent@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135451

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Gmail should not be a bookmark app #

Patch Set 4 : #

Patch Set 5 : Add owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -80 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 12 chunks +35 lines, -52 lines 0 comments Download
M chrome/browser/extensions/external_extension_provider_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_extension_provider_impl.cc View 5 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/extensions/external_extension_provider_interface.h View 1 chunk +0 lines, -4 lines 0 comments Download
A chrome/browser/resources/default_apps/OWNERS View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/default_apps/external_extensions.json View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mihai Parparita -not on Chrome
8 years, 7 months ago (2012-05-03 23:07:22 UTC) #1
asargent_no_longer_on_chrome
lgtm
8 years, 7 months ago (2012-05-04 17:06:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10376004/3001
8 years, 7 months ago (2012-05-04 17:15:30 UTC) #3
commit-bot: I haz the power
Presubmit check for 10376004-3001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-04 17:15:42 UTC) #4
arv (Not doing code reviews)
lgtm
8 years, 7 months ago (2012-05-04 17:22:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10376004/3009
8 years, 7 months ago (2012-05-04 17:24:12 UTC) #6
commit-bot: I haz the power
Try job failure for 10376004-3009 (retry) on win_rel for step "runhooks". It's a second try, ...
8 years, 7 months ago (2012-05-04 17:44:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10376004/3009
8 years, 7 months ago (2012-05-04 20:07:19 UTC) #8
commit-bot: I haz the power
8 years, 7 months ago (2012-05-04 21:57:55 UTC) #9
Change committed as 135451

Powered by Google App Engine
This is Rietveld 408576698