Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4221)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 10376004: Instead of marking all default apps as bookmark apps, allow it to be specified per-app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add owners Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 8f552df91120aa2eeb92293dab583ef6e0e5f893..dd480013ccc1432051f707f480e2b8e4476ab886 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -678,21 +678,6 @@ bool ExtensionService::UpdateExtension(
if (extension && extension->from_bookmark())
creation_flags |= Extension::FROM_BOOKMARK;
- if (extension) {
- // Additionally, if the extension is an external extension, we preserve the
- // creation flags (usually from_bookmark), even if the current pref values
- // don't reflect them. This is to fix http://crbug.com/109791 for users that
- // had default apps updated and lost the from_bookmark bit.
- ProviderCollection::const_iterator i;
- for (i = external_extension_providers_.begin();
- i != external_extension_providers_.end(); ++i) {
- ExternalExtensionProviderInterface* provider = i->get();
- if (provider->HasExtension(extension->id())) {
- creation_flags |= provider->GetCreationFlags();
- break;
- }
- }
- }
installer->set_creation_flags(creation_flags);
installer->set_delete_source(true);
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698