chrome/browser/resources/chromeos/user_images_grid.js - Issue 10376003: Improve accessibility of user image selection screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/user_images_grid.js

Issue 10376003: Improve accessibility of user image selection screen. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments by ivankr Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/chromeos/user_images_grid.js

diff --git a/chrome/browser/resources/chromeos/user_images_grid.js b/chrome/browser/resources/chromeos/user_images_grid.js

index e96e004c312fe7ac32c0ca9436fd14105bc1cb75..78a42d1049f984a3b75d1290ed73e919f8073adb 100644

--- a/chrome/browser/resources/chromeos/user_images_grid.js

+++ b/chrome/browser/resources/chromeos/user_images_grid.js

@@ -32,8 +32,6 @@ cr.define('options', function() {

var imageEl = cr.doc.createElement('img');

imageEl.src = this.dataItem.url;

imageEl.title = this.dataItem.title || '';

- var label = imageEl.src.replace(/(.*\/|\.png)/g, '');

- imageEl.setAttribute('aria-label', label.replace(/_/g, ' '));

if (typeof this.dataItem.clickHandler == 'function')

imageEl.addEventListener('click', this.dataItem.clickHandler);

// Remove any garbage added by GridItem and ListItem decorators.