Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7715)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

Issue 10376003: Improve accessibility of user image selection screen. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments by ivankr Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
diff --git a/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js b/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
index 59eaa02509f69d7cdb7571420c42bc519afec37d..33898acf53ffbb9bb3a0eb2d7fa0339509b775ca 100644
--- a/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
+++ b/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -291,13 +291,13 @@ cr.define('oobe', function() {
/**
* Appends received images to the list.
- * @param {Array.<string>} images An array of URLs to user images.
+ * @param {Array.<Object>} imageInfos An array of data about user images.
* @private
*/
- setUserImages_: function(images) {
+ setUserImages_: function(imageInfos) {
var imageGrid = $('user-image-grid');
- for (var i = 0, url; url = images[i]; i++)
- imageGrid.addItem(url);
+ for (var i = 0, imageInfo; imageInfo = imageInfos[i]; i++)
+ imageGrid.addItem(imageInfo.url, imageInfo.title);
},
/**

Powered by Google App Engine
This is Rietveld 408576698