Issue 10371002: ninja windows: make sure there's a trailing slash on $(VCInstallDir)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10371002: ninja windows: make sure there's a trailing slash on $(VCInstallDir) (Closed)

Created:
8 years, 7 months ago by scottmg

Modified:
8 years, 7 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
https://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

ninja windows: make sure there's a trailing slash on $(VCInstallDir) R=thakis@chromium.org BUG=125640 Committed: https://code.google.com/p/gyp/source/detail?r=1358

Patch Set 2 : fix quotes #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -1 line)			Patch
M	pylib/gyp/msvs_emulation.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	test/win/gyptest-macro-vcinstalldir.py	View		1 chunk	+22 lines, -0 lines	0 comments	Download
A	test/win/vs-macros/test_exists.py	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	test/win/vs-macros/vcinstalldir.gyp	View		1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

LGTM! https://chromiumcodereview.appspot.com/10371002/diff/1/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://chromiumcodereview.appspot.com/10371002/diff/1/pylib/gyp/msvs_emulation.py#newcode157 pylib/gyp/msvs_emulation.py:157: '$(VCInstallDir)': os.path.join(self.vs_version.Path(), 'VC') + "\\", nit: ' not ...

8 years, 7 months ago (2012-05-03 22:28:09 UTC) #2

scottmg

8 years, 7 months ago (2012-05-03 22:41:36 UTC) #3

https://chromiumcodereview.appspot.com/10371002/diff/1/pylib/gyp/msvs_emulati...
File pylib/gyp/msvs_emulation.py (right):

https://chromiumcodereview.appspot.com/10371002/diff/1/pylib/gyp/msvs_emulati...
pylib/gyp/msvs_emulation.py:157: '$(VCInstallDir)':
os.path.join(self.vs_version.Path(), 'VC') + "\\",
On 2012/05/03 22:28:09, Nico wrote:
> nit: ' not ", for local consistency

Done.

5 non-space characters, and I get 40% of them wrong. Curses! :)

Expand Messages | Collapse Messages

Issue 10371002: ninja windows: make sure there's a trailing slash on $(VCInstallDir) (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix quotes #

Messages