lib/compiler/implementation/emitter.dart - Issue 10363003: Compute function types together with the parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/emitter.dart

Issue 10363003: Compute function types together with the parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/compiler/implementation/elements/elements.dart ('K') | « lib/compiler/implementation/elements/elements.dart ('k') | lib/compiler/implementation/native_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/emitter.dart

diff --git a/lib/compiler/implementation/emitter.dart b/lib/compiler/implementation/emitter.dart

index e14c8efe9aa794ab37668f1d89e615077ade5ce7..06626b7af39161f329fa74d9918db497d3ace152 100644

--- a/lib/compiler/implementation/emitter.dart

+++ b/lib/compiler/implementation/emitter.dart

@@ -136,7 +136,7 @@ function() {

Selector selector,

void defineInstanceMember(String invocationName,

String definition)) {

- FunctionParameters parameters = member.computeParameters(compiler);

+ FunctionSignature parameters = member.computeSignature(compiler);

int positionalArgumentCount = selector.positionalArgumentCount;

if (positionalArgumentCount == parameters.parameterCount) {

assert(selector.namedArgumentCount == 0);

@@ -268,7 +268,7 @@ function() {

defineInstanceMember(compiler.namer.getBailoutName(member), codeBlock);

}

FunctionElement function = member;

- FunctionParameters parameters = function.computeParameters(compiler);

+ FunctionSignature parameters = function.computeSignature(compiler);

if (!parameters.optionalParameters.isEmpty()) {

addParameterStubs(member, defineInstanceMember);

}