Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: lib/compiler/implementation/emitter.dart

Issue 10363003: Compute function types together with the parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * A function element that represents a closure call. The signature is copied 6 * A function element that represents a closure call. The signature is copied
7 * from the given element. 7 * from the given element.
8 */ 8 */
9 class ClosureInvocationElement extends FunctionElement { 9 class ClosureInvocationElement extends FunctionElement {
10 ClosureInvocationElement(SourceString name, 10 ClosureInvocationElement(SourceString name,
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 buffer.add("$defineClassName = ${buildDefineClassFunction(isolate)};\n"); 129 buffer.add("$defineClassName = ${buildDefineClassFunction(isolate)};\n");
130 buffer.add("$isolate.pendingClasses = {};\n"); 130 buffer.add("$isolate.pendingClasses = {};\n");
131 buffer.add("$finishClassesName = ${buildFinishClassesFunction(isolate)};"); 131 buffer.add("$finishClassesName = ${buildFinishClassesFunction(isolate)};");
132 buffer.add("\n"); 132 buffer.add("\n");
133 } 133 }
134 134
135 void addParameterStub(FunctionElement member, 135 void addParameterStub(FunctionElement member,
136 Selector selector, 136 Selector selector,
137 void defineInstanceMember(String invocationName, 137 void defineInstanceMember(String invocationName,
138 String definition)) { 138 String definition)) {
139 FunctionParameters parameters = member.computeParameters(compiler); 139 FunctionSignature parameters = member.computeSignature(compiler);
140 int positionalArgumentCount = selector.positionalArgumentCount; 140 int positionalArgumentCount = selector.positionalArgumentCount;
141 if (positionalArgumentCount == parameters.parameterCount) { 141 if (positionalArgumentCount == parameters.parameterCount) {
142 assert(selector.namedArgumentCount == 0); 142 assert(selector.namedArgumentCount == 0);
143 return; 143 return;
144 } 144 }
145 ConstantHandler handler = compiler.constantHandler; 145 ConstantHandler handler = compiler.constantHandler;
146 List<SourceString> names = selector.getOrderedNamedArguments(); 146 List<SourceString> names = selector.getOrderedNamedArguments();
147 147
148 String invocationName = 148 String invocationName =
149 namer.instanceMethodInvocationName(member.getLibrary(), member.name, 149 namer.instanceMethodInvocationName(member.getLibrary(), member.name,
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 || member.kind === ElementKind.SETTER) { 261 || member.kind === ElementKind.SETTER) {
262 if (member.modifiers !== null && member.modifiers.isAbstract()) return; 262 if (member.modifiers !== null && member.modifiers.isAbstract()) return;
263 String codeBlock = compiler.universe.generatedCode[member]; 263 String codeBlock = compiler.universe.generatedCode[member];
264 if (codeBlock == null) return; 264 if (codeBlock == null) return;
265 defineInstanceMember(namer.getName(member), codeBlock); 265 defineInstanceMember(namer.getName(member), codeBlock);
266 codeBlock = compiler.universe.generatedBailoutCode[member]; 266 codeBlock = compiler.universe.generatedBailoutCode[member];
267 if (codeBlock !== null) { 267 if (codeBlock !== null) {
268 defineInstanceMember(compiler.namer.getBailoutName(member), codeBlock); 268 defineInstanceMember(compiler.namer.getBailoutName(member), codeBlock);
269 } 269 }
270 FunctionElement function = member; 270 FunctionElement function = member;
271 FunctionParameters parameters = function.computeParameters(compiler); 271 FunctionSignature parameters = function.computeSignature(compiler);
272 if (!parameters.optionalParameters.isEmpty()) { 272 if (!parameters.optionalParameters.isEmpty()) {
273 addParameterStubs(member, defineInstanceMember); 273 addParameterStubs(member, defineInstanceMember);
274 } 274 }
275 } else if (member.kind === ElementKind.FIELD) { 275 } else if (member.kind === ElementKind.FIELD) {
276 // TODO(ngeoffray): Have another class generate the code for the 276 // TODO(ngeoffray): Have another class generate the code for the
277 // fields. 277 // fields.
278 if ((member.modifiers === null || !member.modifiers.isFinal()) && 278 if ((member.modifiers === null || !member.modifiers.isFinal()) &&
279 compiler.universe.hasSetter(member, compiler)) { 279 compiler.universe.hasSetter(member, compiler)) {
280 String setterName = namer.setterName(member.getLibrary(), member.name); 280 String setterName = namer.setterName(member.getLibrary(), member.name);
281 String name = member.isNative() 281 String name = member.isNative()
(...skipping 553 matching lines...) Expand 10 before | Expand all | Expand 10 after
835 emitFinishClassesInvocationIfNecessary(mainBuffer); 835 emitFinishClassesInvocationIfNecessary(mainBuffer);
836 emitMain(mainBuffer); 836 emitMain(mainBuffer);
837 mainBuffer.add('function init() {\n'); 837 mainBuffer.add('function init() {\n');
838 addDefineClassAndFinishClassFunctionsIfNecessary(mainBuffer); 838 addDefineClassAndFinishClassFunctionsIfNecessary(mainBuffer);
839 mainBuffer.add('}\n'); 839 mainBuffer.add('}\n');
840 compiler.assembledCode = mainBuffer.toString(); 840 compiler.assembledCode = mainBuffer.toString();
841 }); 841 });
842 return compiler.assembledCode; 842 return compiler.assembledCode;
843 } 843 }
844 } 844 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698