Issue 10356025: chrome: Instead of doing a conversion just use string16().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10356025: chrome: Instead of doing a conversion just use string16(). (Closed)

Created:
8 years, 7 months ago by tfarina

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome: Instead of doing a conversion just use string16(). See chromium-dev thread for reference: https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/ec912e667c6fdec8# This patch fixes almost all the entries, remaining only one entry in webkit/ directory that will be sent for review separately. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135581

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Patch Set 3 : avoid temp var at all #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
M	chrome/browser/extensions/convert_user_script_unittest.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_unittest.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 7 months ago (2012-05-04 21:20:59 UTC) #2

lgtm

http://codereview.chromium.org/10356025/diff/1/chrome/renderer/spellchecker/s...
File chrome/renderer/spellchecker/spellcheck_unittest.cc (right):

http://codereview.chromium.org/10356025/diff/1/chrome/renderer/spellchecker/s...
chrome/renderer/spellchecker/spellcheck_unittest.cc:850: const string16 text();
text;

Expand Messages | Collapse Messages