Issue 10349008: Set the right context to resolve types of fields, closures and parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10349008: Set the right context to resolve types of fields, closures and parameters. (Closed)

Created:
8 years, 7 months ago by karlklose

Modified:
8 years, 7 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Set the right context to resolve types of fields, closures and parameters. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=7373

Patch Set 3 : Address Kasper's comments. #

Total comments: 1

Patch Set 4 : Remove fix for factories. This should be fixed in the parser. #

Patch Set 5 : Merge and add test. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -6 lines)			Patch
M	frog/tests/leg/resolver_test.dart	View	1 2 3 4	1 chunk	+14 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1 2 3	2 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

http://codereview.chromium.org/10349008/diff/2002/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): http://codereview.chromium.org/10349008/diff/2002/lib/compiler/implementation/resolver.dart#newcode583 lib/compiler/implementation/resolver.dart:583: LibraryElement library = element.getLibrary(); How about a helper function ...

8 years, 7 months ago (2012-05-03 13:25:28 UTC) #2

ngeoffray

8 years, 7 months ago (2012-05-07 09:32:30 UTC) #3

LGTM, but can we write a test that actually fails? (and just not emits warnings)

http://codereview.chromium.org/10349008/diff/5001/lib/compiler/implementation...
File lib/compiler/implementation/resolver.dart (right):

http://codereview.chromium.org/10349008/diff/5001/lib/compiler/implementation...
lib/compiler/implementation/resolver.dart:1079: return compiler.dynamicClass;
You can remove this check, we have a fix:
https://chromiumcodereview.appspot.com/10332032