Canonicalize the reference_dir also when canonicalizing a path

Canonicalize the reference_dir also when canonicalizing a path
Committed: https://code.google.com/p/dart/source/detail?r=7265

[cshapiro, 2012-05-03 00:17:21]

lgtm

http://codereview.chromium.org/10344010/diff/1/bin/dartutils.cc
File bin/dartutils.cc (right):

http://codereview.chromium.org/10344010/diff/1/bin/dartutils.cc#newcode240
bin/dartutils.cc:240: char* path_sep = strrchr(canonical_path,
File::PathSeparator()[0]);
Since there is no equivalent of the STL string .rfind method in the C standard
library, maybe add a ASSERT(strlen(File::PathSeparator()) == 1) just in case?

http://codereview.chromium.org/10344010/diff/1/bin/dartutils.cc#newcode247
bin/dartutils.cc:247: intptr_t len = snprintf(NULL, 0, "%s%s%s",
As an aside, we really need an abstraction to do this.  For example, glibc has a
function called asprintf which allocates a formatted string.

http://codereview.chromium.org/10344010/diff/1/bin/dartutils.cc#newcode256
bin/dartutils.cc:256: if  (canonical_path == NULL) {
horizontal whitespace

[siva, 2012-05-03 00:46:05]

http://codereview.chromium.org/10344010/diff/1/bin/dartutils.cc
File bin/dartutils.cc (right):

http://codereview.chromium.org/10344010/diff/1/bin/dartutils.cc#newcode240
bin/dartutils.cc:240: char* path_sep = strrchr(canonical_path,
File::PathSeparator()[0]);
On 2012/05/03 00:17:21, cshapiro wrote:
> Since there is no equivalent of the STL string .rfind method in the C standard
> library, maybe add a ASSERT(strlen(File::PathSeparator()) == 1) just in case?

Done.

http://codereview.chromium.org/10344010/diff/1/bin/dartutils.cc#newcode247
bin/dartutils.cc:247: intptr_t len = snprintf(NULL, 0, "%s%s%s",
Agree, maybe we could add a method in utils.

On 2012/05/03 00:17:21, cshapiro wrote:
> As an aside, we really need an abstraction to do this.  For example, glibc has
a
> function called asprintf which allocates a formatted string.

http://codereview.chromium.org/10344010/diff/1/bin/dartutils.cc#newcode256
bin/dartutils.cc:256: if  (canonical_path == NULL) {
Removed.

On 2012/05/03 00:17:21, cshapiro wrote:
> horizontal whitespace