Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h

Issue 10332185: Update behavior of one-click infobar to remove modal dialog, add "undo". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't call ok in tests of advanced link Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h
index 0a0261b36464c3ec2c452936d4c4889f1733adaf..a3417b6a7e23855e88e31610c4d63dd8197542c3 100644
--- a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h
@@ -18,11 +18,9 @@
@interface OneClickSigninBubbleController : BaseBubbleController {
@private
IBOutlet NSTextField* messageField_;
- IBOutlet NSButton* learnMoreLink_;
akalin 2012/05/17 00:39:24 leave this variable in, and add a TODO for me to r
Roger Tawa OOO till Jul 10th 2012/05/17 21:17:37 Done.
IBOutlet NSButton* advancedLink_;
- base::Closure learnMoreCallback_;
- base::Closure advancedCallback_;
+ base::Callback<void(bool)> start_sync_callback_;
}
// Initializes with a browser window controller, under whose wrench
@@ -32,14 +30,13 @@
// The bubble is not automatically displayed; call showWindow:id to
// display. The bubble is auto-released on close.
- (id)initWithBrowserWindowController:(BrowserWindowController*)controller
- learnMoreCallback:(const base::Closure&)learnMoreCallback
- advancedCallback:(const base::Closure&)advancedCallback;
+ start_sync_callback:(const base::Callback<void(bool)>&)start_sync_callback;
akalin 2012/05/17 00:39:24 obj-c style is to align the :s. If you use 'const
-// Just closes the bubble.
+// Starts sync and closes teh bubble..
akalin 2012/05/17 00:39:24 typo
Roger Tawa OOO till Jul 10th 2012/05/17 21:17:37 Done.
- (IBAction)ok:(id)sender;
-// Calls |learnMoreCallback_|.
-- (IBAction)onClickLearnMoreLink:(id)sender;
+// Just closes the bubble.
akalin 2012/05/17 00:39:24 this would require nib changes too. Just leave th
Roger Tawa OOO till Jul 10th 2012/05/17 21:17:37 Done.
+- (IBAction)undo:(id)sender;
// Calls |advancedCallback_|.
- (IBAction)onClickAdvancedLink:(id)sender;

Powered by Google App Engine
This is Rietveld 408576698