Update behavior of one-click infobar to remove modal dialog, add "undo".

chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_ONE_CLICK_SIGNIN_DIALOG_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_ONE_CLICK_SIGNIN_DIALOG_CONTROLLER_H_
 #pragma once
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/callback.h"
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 
 @class BrowserWindowController;
 
 // Displays the one-click signin confirmation bubble (after syncing
 // has started).
 @interface OneClickSigninBubbleController : BaseBubbleController {
  @private
   IBOutlet NSTextField* messageField_;
-  IBOutlet NSButton* learnMoreLink_;

[akalin, 2012/05/17 00:39:24]

leave this variable in, and add a TODO for me to remove it (it requires nib
changes)

[Roger Tawa OOO till Jul 10th, 2012/05/17 21:17:37]

Done.

   IBOutlet NSButton* advancedLink_;
 
-  base::Closure learnMoreCallback_;
-  base::Closure advancedCallback_;
+  base::Callback<void(bool)> start_sync_callback_;
 }
 
 // Initializes with a browser window controller, under whose wrench
 // menu this bubble will be displayed, and callbacks which are called
 // if the user clicks the corresponding link.
 //
 // The bubble is not automatically displayed; call showWindow:id to
 // display.  The bubble is auto-released on close.
 - (id)initWithBrowserWindowController:(BrowserWindowController*)controller
-                    learnMoreCallback:(const base::Closure&)learnMoreCallback
-                     advancedCallback:(const base::Closure&)advancedCallback;
+    start_sync_callback:(const base::Callback<void(bool)>&)start_sync_callback;

[akalin, 2012/05/17 00:39:24]

obj-c style is to align the :s.  If you use 'const StartSyncCallback&' I think
it'll fit

+
+// Starts sync and closes teh bubble..

[akalin, 2012/05/17 00:39:24]

typo

[Roger Tawa OOO till Jul 10th, 2012/05/17 21:17:37]

Done.

+- (IBAction)ok:(id)sender;
 
 // Just closes the bubble.

[akalin, 2012/05/17 00:39:24]

this would require nib changes too.  Just leave this out and put a TODO for me
to add it in.

[Roger Tawa OOO till Jul 10th, 2012/05/17 21:17:37]

Done.

-- (IBAction)ok:(id)sender;
-
-// Calls |learnMoreCallback_|.
-- (IBAction)onClickLearnMoreLink:(id)sender;
+- (IBAction)undo:(id)sender;
 
 // Calls |advancedCallback_|.
 - (IBAction)onClickAdvancedLink:(id)sender;
 
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_ONE_CLICK_SIGNIN_DIALOG_CONTROLLER_H_