Chromium Code Reviews| Index: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h |
| diff --git a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h |
| index 0a0261b36464c3ec2c452936d4c4889f1733adaf..a3417b6a7e23855e88e31610c4d63dd8197542c3 100644 |
| --- a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h |
| +++ b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h |
| @@ -18,11 +18,9 @@ |
| @interface OneClickSigninBubbleController : BaseBubbleController { |
| @private |
| IBOutlet NSTextField* messageField_; |
| - IBOutlet NSButton* learnMoreLink_; |
|
akalin
2012/05/17 00:39:24
leave this variable in, and add a TODO for me to r
Roger Tawa OOO till Jul 10th
2012/05/17 21:17:37
Done.
|
| IBOutlet NSButton* advancedLink_; |
| - base::Closure learnMoreCallback_; |
| - base::Closure advancedCallback_; |
| + base::Callback<void(bool)> start_sync_callback_; |
| } |
| // Initializes with a browser window controller, under whose wrench |
| @@ -32,14 +30,13 @@ |
| // The bubble is not automatically displayed; call showWindow:id to |
| // display. The bubble is auto-released on close. |
| - (id)initWithBrowserWindowController:(BrowserWindowController*)controller |
| - learnMoreCallback:(const base::Closure&)learnMoreCallback |
| - advancedCallback:(const base::Closure&)advancedCallback; |
| + start_sync_callback:(const base::Callback<void(bool)>&)start_sync_callback; |
|
akalin
2012/05/17 00:39:24
obj-c style is to align the :s. If you use 'const
|
| -// Just closes the bubble. |
| +// Starts sync and closes teh bubble.. |
|
akalin
2012/05/17 00:39:24
typo
Roger Tawa OOO till Jul 10th
2012/05/17 21:17:37
Done.
|
| - (IBAction)ok:(id)sender; |
| -// Calls |learnMoreCallback_|. |
| -- (IBAction)onClickLearnMoreLink:(id)sender; |
| +// Just closes the bubble. |
|
akalin
2012/05/17 00:39:24
this would require nib changes too. Just leave th
Roger Tawa OOO till Jul 10th
2012/05/17 21:17:37
Done.
|
| +- (IBAction)undo:(id)sender; |
| // Calls |advancedCallback_|. |
| - (IBAction)onClickAdvancedLink:(id)sender; |