Fix flakiness in login_utils_browsertest.cc.

Fix flakiness in login_utils_browsertest.cc.

BUG=None
TEST=LoginUtils* browsertests stop flaking

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135355

[Mattias Nissler (ping if slow), 2012-05-04 13:45:03]

http://codereview.chromium.org/10317016/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/login_utils_browsertest.cc (right):

http://codereview.chromium.org/10317016/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/login_utils_browsertest.cc:93: template<typename
TESTBASE>
while you're at it, how about changing this to use
testing::TestWithParamInterface?

[Joao da Silva, 2012-05-04 14:23:10]

http://codereview.chromium.org/10317016/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/login_utils_browsertest.cc (right):

http://codereview.chromium.org/10317016/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/login_utils_browsertest.cc:93: template<typename
TESTBASE>
On 2012/05/04 13:45:04, Mattias Nissler wrote:
> while you're at it, how about changing this to use
> testing::TestWithParamInterface?

Sure, done.

[Mattias Nissler (ping if slow), 2012-05-04 14:26:14]

LGTM

[Bernhard Bauer, 2012-05-04 16:27:21]

Post-commit drive-by: Usually it's nice to explain in the CL description what
the problem was instead of only mentioning that it's fixed now (which should be
implicit).

[Joao da Silva, 2012-05-04 16:32:43]

On 2012/05/04 16:27:21, Bernhard Bauer wrote:
> Post-commit drive-by: Usually it's nice to explain in the CL description what
> the problem was instead of only mentioning that it's fixed now (which should
be
> implicit).

Will do next time :-) I suspect the root cause of the flakiness for this test
might also cause flakes in other tests, and I've reported that on chromium-dev.