Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 10317011: Associate variation IDs with uniformity trials. (Closed)

Created:
8 years, 7 months ago by SteveT
Modified:
8 years, 7 months ago
Reviewers:
MAD, jwd
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Associate variation IDs with uniformity trials. BUG=124391 TEST=Run with -v=1 and make sure the correct field trial names and group names are being outputted by the log. Ensure that once we start transmitting variation IDs, these IDs begin appearing on the server. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135353

Patch Set 1 : init #

Total comments: 2

Patch Set 2 : kUniformityBase = kMinID #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M chrome/browser/chrome_browser_main.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/common/metrics/variation_ids.h View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
SteveT
PTAL.
8 years, 7 months ago (2012-05-04 02:18:44 UTC) #1
MAD
Cool stuff... LGTM with one small nit/question... Thanks! BYE MAD... http://codereview.chromium.org/10317011/diff/4002/chrome/common/metrics/variation_ids.h File chrome/common/metrics/variation_ids.h (right): http://codereview.chromium.org/10317011/diff/4002/chrome/common/metrics/variation_ids.h#newcode48 ...
8 years, 7 months ago (2012-05-04 12:32:54 UTC) #2
SteveT
Response to MAD's nit. http://codereview.chromium.org/10317011/diff/4002/chrome/common/metrics/variation_ids.h File chrome/common/metrics/variation_ids.h (right): http://codereview.chromium.org/10317011/diff/4002/chrome/common/metrics/variation_ids.h#newcode48 chrome/common/metrics/variation_ids.h:48: kUniformity1PercentBase = 3300000, On 2012/05/04 ...
8 years, 7 months ago (2012-05-04 13:20:36 UTC) #3
SteveT
Oops - meant to say that I would do it now. For a second I ...
8 years, 7 months ago (2012-05-04 13:29:01 UTC) #4
SteveT
Oops - meant to say that I would do it now. For a second I ...
8 years, 7 months ago (2012-05-04 13:29:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/10317011/12001
8 years, 7 months ago (2012-05-04 14:09:18 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-04 15:57:44 UTC) #7
Change committed as 135353

Powered by Google App Engine
This is Rietveld 408576698