Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: build/android/test_result.py

Issue 10310046: Detect crashes while running native tests in APK. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/test_result.py
diff --git a/build/android/test_result.py b/build/android/test_result.py
index dfafca7007fd84c71023419b5bff98c1bafff847..7a5ce1238dca4ad30ab2aa4ff7a451f12ec6fe9b 100644
--- a/build/android/test_result.py
+++ b/build/android/test_result.py
@@ -61,10 +61,12 @@ class TestResults(object):
self.overall_fail = False
@staticmethod
- def FromOkAndFailed(ok, failed, timed_out, overall_fail):
+ def FromRun(ok=[], failed=[], crashed=[], timed_out=False,
John Grabowski 2012/05/08 12:54:10 default args which are lists violate the style gui
nilesh 2012/05/08 22:18:44 Done.
+ overall_fail=False):
ret = TestResults()
ret.ok = ok
ret.failed = failed
+ ret.crashed = crashed
ret.timed_out = timed_out
ret.overall_fail = overall_fail
return ret

Powered by Google App Engine
This is Rietveld 408576698