Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4165)

Unified Diff: build/android/single_test_runner.py

Issue 10310046: Detect crashes while running native tests in APK. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/single_test_runner.py
diff --git a/build/android/single_test_runner.py b/build/android/single_test_runner.py
index fe59cb6cbd42e6e289e0b76882a9d64fd874b7af..2505377aaaaac9ac38fce9006a28a30c1db12542 100644
--- a/build/android/single_test_runner.py
+++ b/build/android/single_test_runner.py
@@ -271,10 +271,9 @@ class SingleTestRunner(BaseTestRunner):
logging.info('*' * 80)
if executed_names == all_tests:
break
- self.test_results = TestResults.FromOkAndFailed(list(executed_results -
- failed_results),
- list(failed_results),
- False, False)
+ self.test_results = TestResults.FromRun(
+ ok=list(executed_results - failed_results),
John Grabowski 2012/05/08 12:54:10 use consistent indent (e.g. unindent line 276 by 2
nilesh 2012/05/08 22:18:44 Done.
+ failed=list(failed_results))
def RunTests(self):
"""Runs all tests (in rebaseline mode, runs each test in isolation).

Powered by Google App Engine
This is Rietveld 408576698