Make sure only the main browser process and service proceses are allowed to create the profile dire…

chrome/common/chrome_paths.cc

Index: chrome/common/chrome_paths.cc
diff --git a/chrome/common/chrome_paths.cc b/chrome/common/chrome_paths.cc
index 6d4849e8e10e5c31de9dba9c3c3f59b02c520ce1..69ab46514cd57e9b410541fee7d774a2fbb85d1d 100644
--- a/chrome/common/chrome_paths.cc
+++ b/chrome/common/chrome_paths.cc
@@ -71,6 +71,13 @@ const FilePath::CharType kGTalkPluginFileName[] =
     FILE_PATH_LITERAL("pepper/libppgoogletalk.so");
 
 #endif  // defined(OS_POSIX) && !defined(OS_MACOSX)
+
+#if defined(OS_WIN)
+// TODO(pastarmovj): Remove this copy of switches::kProcessType once we get
+// better way to share constants between content and chrome. Using content
+// switches makes all hell break loose on us when linking.

[jam, 2012/05/02 17:29:52]

I don't understand this comment. Many switches in
content/public/common/content_switches are used in chrome. they just need
CONTENT_EXPORT, which kProcessType has. 

[pastarmovj, 2012/05/03 16:48:24]

After our offline discussion I came up with new version which fixes the broken
project crash_service_win64 in a pattern that other projects have already used.

+const char kProcessTypeSwitch[] = "type";

[cpu_(ooo_6.6-7.5), 2012/05/02 17:33:48]

asking john (jam) what is the way to go here.

+#endif  // defined(OS_WIN)
 }  // namespace
 
 namespace chrome {
@@ -132,6 +139,9 @@ bool PathProvider(int key, FilePath* result) {
   FilePath cur;
   switch (key) {
     case chrome::DIR_USER_DATA:
+      CHECK(ProcessNeedsProfileDir(
+          CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+              kProcessTypeSwitch)));

[cpu_(ooo_6.6-7.5), 2012/05/02 17:33:48]

thanks! no sandboxed process should me trafficking with our profile dir.

[pastarmovj, 2012/05/03 16:48:24]

I am glad to be useful :)

       if (!GetDefaultUserDataDirectory(&cur)) {
         NOTREACHED();
         return false;