Make sure only the main browser process and service proceses are allowed to create the profile dire…

chrome/common/chrome_paths.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_paths.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
@@ skipping 53 matching lines @@
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
 
 const FilePath::CharType kO3DPluginFileName[] =
     FILE_PATH_LITERAL("pepper/libppo3dautoplugin.so");
 
 const FilePath::CharType kGTalkPluginFileName[] =
     FILE_PATH_LITERAL("pepper/libppgoogletalk.so");
 
 #endif  // defined(OS_POSIX) && !defined(OS_MACOSX)
+
+#if defined(OS_WIN)
+// TODO(pastarmovj): Remove this copy of switches::kProcessType once we get
+// better way to share constants between content and chrome. Using content
+// switches makes all hell break loose on us when linking.

[jam, 2012/05/02 17:29:52]

I don't understand this comment. Many switches in
content/public/common/content_switches are used in chrome. they just need
CONTENT_EXPORT, which kProcessType has. 

[pastarmovj, 2012/05/03 16:48:24]

After our offline discussion I came up with new version which fixes the broken
project crash_service_win64 in a pattern that other projects have already used.

+const char kProcessTypeSwitch[] = "type";

[cpu_(ooo_6.6-7.5), 2012/05/02 17:33:48]

asking john (jam) what is the way to go here.

+#endif  // defined(OS_WIN)
 }  // namespace
 
 namespace chrome {
 
 // Gets the path for internal plugins.
 bool GetInternalPluginsDirectory(FilePath* result) {
 #if defined(OS_MACOSX)
   // If called from Chrome, get internal plugins from a subdirectory of the
   // framework.
   if (base::mac::AmIBundled()) {
@@ skipping 41 matching lines @@
       return PathService::Get(base::FILE_MODULE, result);
   }
 
   // Assume that we will not need to create the directory if it does not exist.
   // This flag can be set to true for the cases where we want to create it.
   bool create_dir = false;
 
   FilePath cur;
   switch (key) {
     case chrome::DIR_USER_DATA:
+      CHECK(ProcessNeedsProfileDir(
+          CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+              kProcessTypeSwitch)));

[cpu_(ooo_6.6-7.5), 2012/05/02 17:33:48]

thanks! no sandboxed process should me trafficking with our profile dir.

[pastarmovj, 2012/05/03 16:48:24]

I am glad to be useful :)

       if (!GetDefaultUserDataDirectory(&cur)) {
         NOTREACHED();
         return false;
       }
       create_dir = true;
       break;
     case chrome::DIR_USER_DOCUMENTS:
       if (!GetUserDocumentsDirectory(&cur))
         return false;
       create_dir = true;
@@ skipping 257 matching lines @@
   return true;
 }
 
 // This cannot be done as a static initializer sadly since Visual Studio will
 // eliminate this object file if there is no direct entry point into it.
 void RegisterPathProvider() {
   PathService::RegisterProvider(PathProvider, PATH_START, PATH_END);
 }
 
 }  // namespace chrome