Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 10302020: Fix issue 2888. (Closed)

Created:
8 years, 7 months ago by siva
Modified:
8 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix issue 2888. Allow for the library tag handler to be setup for the isolate, instead of while loading a script. This ensures that we can use #import on the boot strap libraries like builtin, uri etc. This change results in a dart API change and corresponding modifications are necessary in dartium and App Engine. Committed: https://code.google.com/p/dart/source/detail?r=7506

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -62 lines) Patch
M bin/gen_snapshot.cc View 1 2 chunks +18 lines, -9 lines 0 comments Download
M bin/main.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M include/dart_api.h View 1 chunk +16 lines, -1 line 0 comments Download
M vm/dart_api_impl.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M vm/dart_api_impl_test.cc View 15 chunks +51 lines, -41 lines 0 comments Download
M vm/unit_test.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
siva
8 years, 7 months ago (2012-05-03 21:06:03 UTC) #1
regis
LGTM http://codereview.chromium.org/10302020/diff/1/bin/gen_snapshot.cc File bin/gen_snapshot.cc (right): http://codereview.chromium.org/10302020/diff/1/bin/gen_snapshot.cc#newcode293 bin/gen_snapshot.cc:293: Dart_Handle result = Dart_SetLibraryTagHandler(BuiltinLibraryTagHandler); This declaration shadows the ...
8 years, 7 months ago (2012-05-03 21:35:29 UTC) #2
siva
http://codereview.chromium.org/10302020/diff/1/bin/gen_snapshot.cc File bin/gen_snapshot.cc (right): http://codereview.chromium.org/10302020/diff/1/bin/gen_snapshot.cc#newcode293 bin/gen_snapshot.cc:293: Dart_Handle result = Dart_SetLibraryTagHandler(BuiltinLibraryTagHandler); On 2012/05/03 21:35:30, regis wrote: ...
8 years, 7 months ago (2012-05-03 22:16:55 UTC) #3
siva
8 years, 7 months ago (2012-05-04 00:18:22 UTC) #4
Anton Muhin
8 years, 7 months ago (2012-05-04 10:38:11 UTC) #5
Siva,

it should be trivial to adjust Dartium code, the only problem is logistic: I am
leaving early today and we have holidays for the first half of the next week.

If you like, I can prepare a CL tomorrow (it's official business day over here).

Powered by Google App Engine
This is Rietveld 408576698