Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 10274013: Revert order of EXTENSION_LOADED and EXTENSION_INSTALLED notifications back to (Closed)

Created:
8 years, 7 months ago by Matt Perry
Modified:
8 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Revert order of EXTENSION_LOADED and EXTENSION_INSTALLED notifications back to the original way (installed then loaded). I originally switched the order so I could dispatch the onInstalled event, but doing so in a PostTask is a better solution to that. BUG=no TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134653

Patch Set 1 #

Patch Set 2 : compile #

Patch Set 3 : compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -39 lines) Patch
M chrome/browser/chromeos/ui/screensaver_extension_dialog.cc View 1 1 chunk +6 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/extensions/component_loader_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 5 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/extensions/test_extension_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_service.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Matt Perry
8 years, 7 months ago (2012-04-30 20:52:40 UTC) #1
Aaron Boodman
awesome, lgtm
8 years, 7 months ago (2012-04-30 21:00:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10274013/1
8 years, 7 months ago (2012-04-30 21:03:08 UTC) #3
commit-bot: I haz the power
Try job failure for 10274013-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-04-30 21:28:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10274013/10004
8 years, 7 months ago (2012-04-30 23:37:15 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 01:03:25 UTC) #6
Change committed as 134653

Powered by Google App Engine
This is Rietveld 408576698