Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1727)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 10274013: Revert order of EXTENSION_LOADED and EXTENSION_INSTALLED notifications back to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_event_router.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index 349a7a6d37d45d68284e8c2778c2a10c2c4a62be..f8b2148c904ce125f4261eba20001d445f8ea25c 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -124,8 +124,7 @@ class ExtensionServiceInterface : public SyncableService {
// themes sync to not use it directly.
virtual void CheckForUpdatesSoon() = 0;
- // Returns true if the extension was successfully added.
- virtual bool AddExtension(const Extension* extension) = 0;
+ virtual void AddExtension(const Extension* extension) = 0;
virtual void UnloadExtension(
const std::string& extension_id,
@@ -398,7 +397,7 @@ class ExtensionService
// Adds |extension| to this ExtensionService and notifies observers than an
// extension has been loaded. Called by the backend after an extension has
// been loaded from a file and installed.
- virtual bool AddExtension(const Extension* extension) OVERRIDE;
+ virtual void AddExtension(const Extension* extension) OVERRIDE;
// Called by the backend when an extension has been installed.
void OnExtensionInstalled(
« no previous file with comments | « chrome/browser/extensions/extension_event_router.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698