Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3203)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit.h

Issue 10273019: Omnibox: Add logging of what type of page was displayed when it's used (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Line wrapping. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/autocomplete.cc ('k') | chrome/browser/autocomplete/autocomplete_edit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_edit.h
diff --git a/chrome/browser/autocomplete/autocomplete_edit.h b/chrome/browser/autocomplete/autocomplete_edit.h
index 2ee2d3beb3dbb23899a1f012335f89913ffc0ec8..ce827ca8ebdce898bd7dfc5e35e018d9534afd32 100644
--- a/chrome/browser/autocomplete/autocomplete_edit.h
+++ b/chrome/browser/autocomplete/autocomplete_edit.h
@@ -12,6 +12,7 @@
#include "chrome/browser/autocomplete/autocomplete_controller_delegate.h"
#include "chrome/browser/autocomplete/autocomplete_match.h"
#include "chrome/common/instant_types.h"
+#include "chrome/common/metrics/proto/omnibox_event.pb.h"
#include "content/public/common/page_transition_types.h"
#include "googleurl/src/gurl.h"
#include "ui/gfx/native_widget_types.h"
@@ -444,6 +445,13 @@ class AutocompleteEditModel : public AutocompleteControllerDelegate {
// keyword.
static bool IsSpaceCharForAcceptingKeyword(wchar_t c);
+ // Classify the current page being viewed as, for example, the new tab
+ // page or a normal web page. Used for logging omnibox events for
+ // UMA opted-in users. Examines the user's profile to determine if the
+ // current page is the user's home page.
+ metrics::OmniboxEventProto::PageClassification ClassifyPage(
+ const GURL& gurl) const;
+
scoped_ptr<AutocompleteController> autocomplete_controller_;
OmniboxView* view_;
« no previous file with comments | « chrome/browser/autocomplete/autocomplete.cc ('k') | chrome/browser/autocomplete/autocomplete_edit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698