Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit.cc

Issue 10273019: Omnibox: Add logging of what type of page was displayed when it's used (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Line wrapping. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_edit.h ('k') | chrome/browser/metrics/metrics_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_edit.cc
diff --git a/chrome/browser/autocomplete/autocomplete_edit.cc b/chrome/browser/autocomplete/autocomplete_edit.cc
index c6773ff8b9a2980ba552b63535115b558374e8a6..ee39d7d4b3e4989cab06a5bb76248dd7bf1f0ad8 100644
--- a/chrome/browser/autocomplete/autocomplete_edit.cc
+++ b/chrome/browser/autocomplete/autocomplete_edit.cc
@@ -27,6 +27,7 @@
#include "chrome/browser/instant/instant_controller.h"
#include "chrome/browser/net/predictor.h"
#include "chrome/browser/net/url_fixer_upper.h"
+#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/prerender/prerender_field_trial.h"
#include "chrome/browser/prerender/prerender_manager.h"
#include "chrome/browser/prerender/prerender_manager_factory.h"
@@ -41,6 +42,8 @@
#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_switches.h"
+#include "chrome/common/metrics/proto/omnibox_event.pb.h"
+#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/render_view_host.h"
@@ -518,6 +521,8 @@ void AutocompleteEditModel::OpenMatch(const AutocompleteMatch& match,
autocomplete_controller_->input().type(),
popup_->selected_line(),
-1, // don't yet know tab ID; set later if appropriate
+ ClassifyPage(controller_->GetTabContentsWrapper()->
+ web_contents()->GetURL()),
base::TimeTicks::Now() - time_user_first_modified_omnibox_,
0, // inline autocomplete length; possibly set later
result());
@@ -1138,3 +1143,17 @@ bool AutocompleteEditModel::IsSpaceCharForAcceptingKeyword(wchar_t c) {
return false;
}
}
+
+metrics::OmniboxEventProto::PageClassification
+ AutocompleteEditModel::ClassifyPage(const GURL& gurl) const {
+ if (!gurl.is_valid())
+ return metrics::OmniboxEventProto_PageClassification_INVALID_SPEC;
+ const std::string& url = gurl.spec();
+ if (url == chrome::kChromeUINewTabURL)
+ return metrics::OmniboxEventProto_PageClassification_NEW_TAB_PAGE;
+ if (url == chrome::kAboutBlankURL)
+ return metrics::OmniboxEventProto_PageClassification_BLANK;
+ if (url == profile()->GetPrefs()->GetString(prefs::kHomePage))
+ return metrics::OmniboxEventProto_PageClassification_HOMEPAGE;
+ return metrics::OmniboxEventProto_PageClassification_OTHER;
+}
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_edit.h ('k') | chrome/browser/metrics/metrics_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698