Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 10272024: There is no reason to not assume that status:null isn't 'M'. (Closed)

Created:
8 years, 7 months ago by M-A Ruel
Modified:
8 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

There is no reason to not assume that status:null isn't 'M'. Rietveld self-corrupts its status all the time, there is not point in bailing just because of that. So just assume it's an 'M' and it'll work fine. In any case, the diff is properly parsed to detect what was the real operation. Add unit test that correctly process a deleted file with status:null. TBR=nsylvain@chromium.org BUG= TEST=A corrupted patchset can still be committed with the Commit Queue. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M rietveld.py View 1 chunk +3 lines, -4 lines 0 comments Download
M tests/rietveld_test.py View 1 chunk +17 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
8 years, 7 months ago (2012-05-01 13:24:16 UTC) #1
Evan Stade
lgtm
8 years, 7 months ago (2012-05-01 16:24:07 UTC) #2
M-A Ruel
TBR'ing since it's a minor change.
8 years, 7 months ago (2012-05-01 18:24:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10272024/1
8 years, 7 months ago (2012-05-01 18:24:40 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 18:32:59 UTC) #5
Change committed as 134733

Powered by Google App Engine
This is Rietveld 408576698