Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: rietveld.py

Issue 10272024: There is no reason to not assume that status:null isn't 'M'. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/rietveld_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rietveld.py
diff --git a/rietveld.py b/rietveld.py
index 6fc5796323958b9c4ecf380d06e2eb51e7987fdf..70c64441fc31a01820c6a59466a6bdb4286c0be6 100644
--- a/rietveld.py
+++ b/rietveld.py
@@ -109,10 +109,9 @@ class Rietveld(object):
out = []
for filename, state in props.get('files', {}).iteritems():
logging.debug('%s' % filename)
- status = state.get('status')
- if not status:
- raise patch.UnsupportedPatchFormat(
- filename, 'File\'s status is None, patchset upload is incomplete.')
+ # If not status, just assume it's a 'M'. Rietveld often gets it wrong and
+ # just has status: null. Oh well.
+ status = state.get('status') or 'M'
if status[0] not in ('A', 'D', 'M'):
raise patch.UnsupportedPatchFormat(
filename, 'Change with status \'%s\' is not supported.' % status)
« no previous file with comments | « no previous file | tests/rietveld_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698