Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 10272004: Move RefCountedMemory class to base namespace. (Closed)

Created:
8 years, 7 months ago by simonhong_
Modified:
8 years, 7 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, asanka, nkostylev+watch_chromium.org, ben+watch_chromium.org, erikwright (departed), mihaip+watch_chromium.org, Randy Smith (Not in Mondays), Aaron Boodman, brettw-cc_chromium.org, estade+watch_chromium.org, tfarina
Visibility:
Public.

Description

Move RefCountedMemory Class to Base namespace BUG=none TEST=compiles chrome, browser_tests and ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135011

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -154 lines) Patch
M base/memory/ref_counted_memory.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M base/memory/ref_counted_memory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_handler.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/favicon/favicon_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/history/history_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_types.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/thumbnail_database.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/thumbnail_database.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/history/top_sites.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/history/top_sites.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/history/top_sites_cache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/top_sites_cache.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/history/top_sites_unittest.cc View 1 2 3 11 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/jumplist_win.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/themes/theme_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/background_theme.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/background_theme.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_data_source_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/register_page_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/conflicts_ui.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/conflicts_ui.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/crashes_ui.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/downloads_ui.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/downloads_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/favicon_source.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/flags_ui.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/flash_ui.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/history_ui.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.h View 1 4 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sessions_ui.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sessions_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/theme_source.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/theme_provider.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/gfx/color_analysis.h View 2 chunks +11 lines, -8 lines 0 comments Download
M ui/gfx/color_analysis.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/views/widget/default_theme_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/default_theme_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
simonhong_
Dear joth, erg Please review this issue. Thank you.
8 years, 7 months ago (2012-04-30 01:17:41 UTC) #1
Elliot Glaysher
I read the entire patch. Other than the one nit in ref_counted_memory.h, lgtm. http://codereview.chromium.org/10272004/diff/3009/base/memory/ref_counted_memory.h File ...
8 years, 7 months ago (2012-05-01 19:08:49 UTC) #2
simonhong_
http://codereview.chromium.org/10272004/diff/3009/base/memory/ref_counted_memory.h File base/memory/ref_counted_memory.h (right): http://codereview.chromium.org/10272004/diff/3009/base/memory/ref_counted_memory.h#newcode19 base/memory/ref_counted_memory.h:19: namespace base { On 2012/05/01 19:08:49, Elliot Glaysher wrote: ...
8 years, 7 months ago (2012-05-01 19:17:25 UTC) #3
simonhong_
Dear brettw, ben Please review this issue. brettw: base/* chrome/* ben: ui/* Thank you.
8 years, 7 months ago (2012-05-01 19:28:13 UTC) #4
Ben Goodger (Google)
LGTM for ui/
8 years, 7 months ago (2012-05-01 19:32:37 UTC) #5
brettw
base LGTM
8 years, 7 months ago (2012-05-01 21:26:22 UTC) #6
simonhong_
Could I check commit box? Or need more stamp sub dirs in the chrome/ ? ...
8 years, 7 months ago (2012-05-01 23:10:34 UTC) #7
Elliot Glaysher
On 2012/05/01 23:10:34, Simon Hong wrote: > Could I check commit box? > Or need ...
8 years, 7 months ago (2012-05-02 00:23:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/10272004/11013
8 years, 7 months ago (2012-05-02 00:23:19 UTC) #9
commit-bot: I haz the power
Try job failure for 10272004-11013 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-02 00:50:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/10272004/26001
8 years, 7 months ago (2012-05-02 20:49:02 UTC) #11
commit-bot: I haz the power
8 years, 7 months ago (2012-05-02 22:37:46 UTC) #12
Change committed as 135011

Powered by Google App Engine
This is Rietveld 408576698