Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2735)

Unified Diff: base/memory/ref_counted_memory.h

Issue 10272004: Move RefCountedMemory class to base namespace. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/memory/ref_counted_memory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/ref_counted_memory.h
===================================================================
--- base/memory/ref_counted_memory.h (revision 134496)
+++ base/memory/ref_counted_memory.h (working copy)
@@ -13,8 +13,7 @@
#include "base/compiler_specific.h"
#include "base/memory/ref_counted.h"
-// TODO(erg): The contents of this file should be in a namespace. This would
-// require touching >100 files in chrome/ though.
+namespace base {
// A generic interface to memory. This object is reference counted because one
// of its two subclasses own the data they carry, and we need to have
@@ -35,8 +34,6 @@
virtual ~RefCountedMemory();
};
-namespace base {
-
// An implementation of RefCountedMemory, where the ref counting does not
// matter.
class BASE_EXPORT RefCountedStaticMemory : public RefCountedMemory {
« no previous file with comments | « no previous file | base/memory/ref_counted_memory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698