Change PrerenderContents::render_view_host from hacker_style to StudlyCaps.

Change PrerenderContents::render_view_host from hacker_style to StudlyCaps.

See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Names#Function_Names

Those hacker_style functions were not free like member access, so StudlyTheyMustBe.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134496

[gavinp, 2012-04-29 00:15:43]

dominic, wdyt?

[dominich.google, 2012-04-29 14:15:59]

LGTM. Studlify!
On Apr 28, 2012 5:15 PM, <gavinp@chromium.org> wrote:

> Reviewers: dominich,
>
> Message:
> dominic, wdyt?
>
> Description:
> Change PrerenderContents::render_**view_host from hacker_style to
> StudlyCaps.
>
> See
> http://google-styleguide.**googlecode.com/svn/trunk/**
>
cppguide.xml?showone=Function_**Names#Function_Names<http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Names#Function_Names>
>
> Those hacker_style functions were not free like member access, so
> StudlyTheyMustBe.
>
> BUG=None
>
>
> Please review this at
http://codereview.chromium.**org/10270003/<http://codereview.chromium.org/102...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/prerender/**prerender_browsertest.cc
>  M chrome/browser/prerender/**prerender_contents.h
>  M chrome/browser/prerender/**prerender_contents.cc
>
>
> Index: chrome/browser/prerender/**prerender_browsertest.cc
> diff --git a/chrome/browser/prerender/**prerender_browsertest.cc
> b/chrome/browser/prerender/**prerender_browsertest.cc
> index 7e1edf9552e4b7eb5eedf553403f9a**032f4ed77b..**
> c3e1c860191638fb56fcea1e51edff**ebe6551677 100644
> --- a/chrome/browser/prerender/**prerender_browsertest.cc
> +++ b/chrome/browser/prerender/**prerender_browsertest.cc
> @@ -298,7 +298,7 @@ class TestPrerenderContents : public PrerenderContents
> {
>       } else if (is_visible && was_hidden_) {
>         // Once hidden, a prerendered RenderViewHost should only be shown
> after
>         // being removed from the PrerenderContents for display.
> -        EXPECT_FALSE(render_view_host(**));
> +        EXPECT_FALSE(**GetRenderViewHost());
>         was_shown_ = true;
>       }
>       return;
> @@ -853,7 +853,7 @@ class PrerenderBrowserTest : public
> InProcessBrowserTest {
>         // Check if page behaves as expected while in prerendered state.
>         bool prerender_test_result = false;
>         ASSERT_TRUE(ui_test_utils::**ExecuteJavaScriptAndExtractBoo**l(
> -            prerender_contents->render_**view_host_mutable(), L"",
> +            prerender_contents->**GetRenderViewHostMutable(), L"",
>             L"window.**domAutomationController.send(**
> DidPrerenderPass())",
>             &prerender_test_result));
>         EXPECT_TRUE(prerender_test_**result);
> Index: chrome/browser/prerender/**prerender_contents.cc
> diff --git a/chrome/browser/prerender/**prerender_contents.cc
> b/chrome/browser/prerender/**prerender_contents.cc
> index aefc32eedf39aacb4ca0a6e4e70b64**d59ab1fdd8..**
> 098a67a74cb737c1920b8e06b86768**543ec1dc75 100644
> --- a/chrome/browser/prerender/**prerender_contents.cc
> +++ b/chrome/browser/prerender/**prerender_contents.cc
> @@ -322,10 +322,10 @@ void PrerenderContents::**StartPrerendering(
>
>   // Register as an observer of the RenderViewHost so we get messages.
>   render_view_host_observer_.**reset(
> -      new PrerenderRenderViewHostObserve**r(this,
> render_view_host_mutable()));
> +      new PrerenderRenderViewHostObserve**r(this,
> GetRenderViewHostMutable()));
>
> -  child_id_ = render_view_host()->**GetProcess()->GetID();
> -  route_id_ = render_view_host()->**GetRoutingID();
> +  child_id_ = GetRenderViewHost()->**GetProcess()->GetID();
> +  route_id_ = GetRenderViewHost()->**GetRoutingID();
>
>   // Register this with the ResourceDispatcherHost as a prerender
>   // RenderViewHost. This must be done before the Navigate message to
> catch all
> @@ -634,9 +634,9 @@ void PrerenderContents::Destroy(**FinalStatus
> final_status) {
>  base::ProcessMetrics* PrerenderContents::**MaybeGetProcessMetrics() {
>   if (process_metrics_.get() == NULL) {
>     // If a PrenderContents hasn't started prerending, don't be fully
> formed.
> -    if (!render_view_host() || !render_view_host()->**GetProcess())
> +    if (!GetRenderViewHost() || !GetRenderViewHost()->**GetProcess())
>       return NULL;
> -    base::ProcessHandle handle = render_view_host()->**
> GetProcess()->GetHandle();
> +    base::ProcessHandle handle = GetRenderViewHost()->**
> GetProcess()->GetHandle();
>     if (handle == base::kNullProcessHandle)
>       return NULL;
>  #if !defined(OS_MACOSX)
> @@ -676,11 +676,11 @@ WebContents* PrerenderContents::**GetWebContents() {
>   return prerender_contents_->web_**contents();
>  }
>
> -RenderViewHost* PrerenderContents::render_**view_host_mutable() {
> -  return const_cast<RenderViewHost*>(**render_view_host());
> +RenderViewHost* PrerenderContents::**GetRenderViewHostMutable() {
> +  return const_cast<RenderViewHost*>(**GetRenderViewHost());
>  }
>
> -const RenderViewHost* PrerenderContents::render_**view_host() const {
> +const RenderViewHost* PrerenderContents::**GetRenderViewHost() const {
>   if (!prerender_contents_.get())
>     return NULL;
>   return prerender_contents_->web_**contents()->GetRenderViewHost(**);
> Index: chrome/browser/prerender/**prerender_contents.h
> diff --git a/chrome/browser/prerender/**prerender_contents.h
> b/chrome/browser/prerender/**prerender_contents.h
> index feeb4f43963a6aa7540be0fadf9c17**b8e5686e73..**
> 854c55d2600fc24cfca3635990acc9**a9509357f2 100644
> --- a/chrome/browser/prerender/**prerender_contents.h
> +++ b/chrome/browser/prerender/**prerender_contents.h
> @@ -110,8 +110,9 @@ class PrerenderContents : public
> content::NotificationObserver,
>   // it if not.
>   void DestroyWhenUsingTooManyResourc**es();
>
> -  content::RenderViewHost* render_view_host_mutable();
> -  const content::RenderViewHost* render_view_host() const;
> +  content::RenderViewHost* GetRenderViewHostMutable();
> +  const content::RenderViewHost* GetRenderViewHost() const;
> +
>   string16 title() const { return title_; }
>   int32 page_id() const { return page_id_; }
>   GURL icon_url() const { return icon_url_; }
>
>
>

[commit-bot: I haz the power, 2012-04-29 14:34:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/10270003/1

[commit-bot: I haz the power, 2012-04-29 16:29:11]

Change committed as 134496