Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10269017: Remove scoped_ptr for system tray views (Closed)

Created:
8 years, 7 months ago by stevenjb
Modified:
8 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Remove scoped_ptr for system tray views Views are owned by their parent, so having an additional scoped_ptr to them in the associated item/model is confusing and misleading. BUG=124269 TEST=Test status area Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134710

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -124 lines) Patch
M ash/system/audio/tray_volume.h View 2 chunks +1 line, -2 lines 0 comments Download
M ash/system/audio/tray_volume.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M ash/system/bluetooth/tray_bluetooth.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/system/bluetooth/tray_bluetooth.cc View 3 chunks +13 lines, -9 lines 0 comments Download
M ash/system/brightness/tray_brightness.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/brightness/tray_brightness.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M ash/system/date/tray_date.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/tray_date.cc View 1 4 chunks +10 lines, -6 lines 0 comments Download
M ash/system/ime/tray_ime.h View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/system/ime/tray_ime.cc View 1 3 chunks +22 lines, -14 lines 0 comments Download
M ash/system/network/tray_network.h View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/system/network/tray_network.cc View 1 chunk +19 lines, -13 lines 0 comments Download
M ash/system/power/tray_power.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/power/tray_power.cc View 6 chunks +16 lines, -12 lines 0 comments Download
M ash/system/tray/system_tray_item.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_image_item.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_image_item.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M ash/system/tray_accessibility.h View 2 chunks +1 line, -2 lines 0 comments Download
M ash/system/tray_accessibility.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M ash/system/tray_caps_lock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray_caps_lock.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M ash/system/tray_update.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/system/tray_update.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ash/system/user/tray_user.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/user/tray_user.cc View 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stevenjb
8 years, 7 months ago (2012-04-30 23:20:49 UTC) #1
sadrul
LGTM. Thanks!
8 years, 7 months ago (2012-05-01 13:54:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10269017/4001
8 years, 7 months ago (2012-05-01 15:20:25 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 16:53:12 UTC) #4 
Change committed as 134710

Powered by Google App Engine
This is Rietveld 408576698