Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3028)

Unified Diff: ash/system/tray/tray_image_item.cc

Issue 10269017: Remove scoped_ptr for system tray views (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/tray/tray_image_item.h ('k') | ash/system/tray_accessibility.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/tray/tray_image_item.cc
diff --git a/ash/system/tray/tray_image_item.cc b/ash/system/tray/tray_image_item.cc
index 238cb0cd177243b5a7856ed34bcb63889ccc9290..a92f2ad3baca34dccc6099a7ee1764bf122604aa 100644
--- a/ash/system/tray/tray_image_item.cc
+++ b/ash/system/tray/tray_image_item.cc
@@ -14,22 +14,24 @@ namespace ash {
namespace internal {
TrayImageItem::TrayImageItem(int resource_id)
- : resource_id_(resource_id) {
+ : resource_id_(resource_id),
+ tray_view_(NULL) {
}
TrayImageItem::~TrayImageItem() {}
views::View* TrayImageItem::tray_view() {
- return tray_view_.get();
+ return tray_view_;
}
views::View* TrayImageItem::CreateTrayView(user::LoginStatus status) {
- tray_view_.reset(new TrayItemView);
+ CHECK(tray_view_ == NULL);
+ tray_view_ = new TrayItemView;
tray_view_->CreateImageView();
tray_view_->image_view()->SetImage(ui::ResourceBundle::GetSharedInstance().
GetImageNamed(resource_id_).ToSkBitmap());
tray_view_->SetVisible(GetInitialVisibility());
- return tray_view_.get();
+ return tray_view_;
}
views::View* TrayImageItem::CreateDefaultView(user::LoginStatus status) {
@@ -44,7 +46,7 @@ void TrayImageItem::UpdateAfterLoginStatusChange(user::LoginStatus status) {
}
void TrayImageItem::DestroyTrayView() {
- tray_view_.reset();
+ tray_view_ = NULL;
}
void TrayImageItem::DestroyDefaultView() {
« no previous file with comments | « ash/system/tray/tray_image_item.h ('k') | ash/system/tray_accessibility.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698