DownloadManagerDelegate::ShouldCompleteDownload(callback)

content/public/browser/download_manager_delegate.h

Index: content/public/browser/download_manager_delegate.h
diff --git a/content/public/browser/download_manager_delegate.h b/content/public/browser/download_manager_delegate.h
index 6cc557c6de7a88e5cdbb41f3d5fa28243a551653..8361e1cab75a3f6abfb9965168bfa1fc423626f1 100644
--- a/content/public/browser/download_manager_delegate.h
+++ b/content/public/browser/download_manager_delegate.h
@@ -60,11 +60,14 @@ class CONTENT_EXPORT DownloadManagerDelegate {
   // Allows the delegate to override completion of the download.  If this
   // function returns false, the download completion is delayed and the
   // delegate is responsible for making sure that
-  // DownloadItem::MaybeCompleteDownload is called at some point in the
+  // |maybe_complete_download| is run at some point in the

[Randy Smith (Not in Mondays), 2012/05/01 18:21:49]

I'm not sure maybe_complete_download is the right name for the parameter.  You
want to put yourself in the position of the caller; it's more a signal that
something really has happened?  on_download_ready_for_completion?

[benjhayden, 2012/05/01 19:00:30]

Asanka suggested complete_cb, which is briefer.
LMK if you feel strongly.

[Randy Smith (Not in Mondays), 2012/05/02 18:14:07]

That's fine.

   // future.  Note that at that point this function will be called again,
   // and is responsible for returning true when it really is ok for the
-  // download to complete.
-  virtual bool ShouldCompleteDownload(DownloadItem* item);
+  // download to complete. If this method returns true, then
+  // |maybe_complete_download| will not be run.
+  virtual bool ShouldCompleteDownload(
+      DownloadItem* item,
+      const base::Closure& maybe_complete_download);
 
   // Allows the delegate to override opening the download. If this function
   // returns false, the delegate needs to call