DownloadManagerDelegate::ShouldCompleteDownload(callback)

content/public/browser/download_manager_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_DOWNLOAD_MANAGER_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_DOWNLOAD_MANAGER_DELEGATE_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/callback.h"
@@ skipping 42 matching lines @@
   // download has started, but the TabConetnts has gone away. This lets an
   // delegate return an alternative WebContents. The delegate can return NULL.
   virtual WebContents* GetAlternativeWebContentsToNotifyForDownload();
 
   // Tests if a file type should be opened automatically.
   virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path);
 
   // Allows the delegate to override completion of the download.  If this
   // function returns false, the download completion is delayed and the
   // delegate is responsible for making sure that
-  // DownloadItem::MaybeCompleteDownload is called at some point in the
+  // |maybe_complete_download| is run at some point in the

[Randy Smith (Not in Mondays), 2012/05/01 18:21:49]

I'm not sure maybe_complete_download is the right name for the parameter.  You
want to put yourself in the position of the caller; it's more a signal that
something really has happened?  on_download_ready_for_completion?

[benjhayden, 2012/05/01 19:00:30]

Asanka suggested complete_cb, which is briefer.
LMK if you feel strongly.

[Randy Smith (Not in Mondays), 2012/05/02 18:14:07]

That's fine.

   // future.  Note that at that point this function will be called again,
   // and is responsible for returning true when it really is ok for the
-  // download to complete.
-  virtual bool ShouldCompleteDownload(DownloadItem* item);
+  // download to complete. If this method returns true, then
+  // |maybe_complete_download| will not be run.
+  virtual bool ShouldCompleteDownload(
+      DownloadItem* item,
+      const base::Closure& maybe_complete_download);
 
   // Allows the delegate to override opening the download. If this function
   // returns false, the delegate needs to call
   // DownloadItem::DelayedDownloadOpened when it's done with the item,
   // and is responsible for opening it.  This function is called
   // after the final rename, but before the download state is set to COMPLETED.
   virtual bool ShouldOpenDownload(DownloadItem* item);
 
   // Returns true if we need to generate a binary hash for downloads.
   virtual bool GenerateFileHash();
@@ skipping 37 matching lines @@
   virtual void ChooseSavePath(WebContents* web_contents,
                               const FilePath& suggested_path,
                               const FilePath::StringType& default_extension,
                               bool can_save_as_complete,
                               SaveFilePathPickedCallback callback) {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DOWNLOAD_MANAGER_DELEGATE_H_