Issue 10262014: chrome_frame: Use operator!= from scoped_ptr to check if |ver_system| is NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10262014: chrome_frame: Use operator!= from scoped_ptr to check if |ver_system| is NULL. (Closed)

Created:
8 years, 7 months ago by tfarina

Modified:
8 years, 7 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

chrome_frame: Use operator!= from scoped_ptr to check if |ver_system| is NULL. The pattern get() ? true : false isn't widely used and after this patch has no more occurrences across chromium/src/ codebase. R=tommi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134690

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome_frame/test/test_with_web_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10262014/1

8 years, 7 months ago (2012-05-01 05:46:13 UTC) #3

Change committed as 134690