Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: chrome_frame/test/test_with_web_server.cc

Issue 10262014: chrome_frame: Use operator!= from scoped_ptr to check if |ver_system| is NULL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/test_with_web_server.cc
diff --git a/chrome_frame/test/test_with_web_server.cc b/chrome_frame/test/test_with_web_server.cc
index ca84ec6b774418c2cd9cea59a92ba7aa0594b6b1..7a668db4243faf2aa804baaaab12ca17be141fb5 100644
--- a/chrome_frame/test/test_with_web_server.cc
+++ b/chrome_frame/test/test_with_web_server.cc
@@ -295,7 +295,7 @@ void ChromeFrameTestWithWebServer::VersionTest(BrowserKind browser,
scoped_ptr<Version> ver_user(InstallUtil::GetChromeVersion(dist, false));
ASSERT_TRUE(ver_system.get() || ver_user.get());
- bool system_install = ver_system.get() ? true : false;
+ bool system_install = ver_system != NULL;
FilePath cf_dll_path(installer::GetChromeInstallPath(system_install, dist));
cf_dll_path = cf_dll_path.Append(UTF8ToWide(
ver_system.get() ? ver_system->GetString() : ver_user->GetString()));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698