Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/isolate/isolate_smoke_test.py

Issue 10261010: Add --mode=noop so progress can be made while the builders are being reconfigured (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/isolate/isolate.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/isolate_smoke_test.py
diff --git a/tools/isolate/isolate_smoke_test.py b/tools/isolate/isolate_smoke_test.py
index db62c630a646e82114596895015e8847d443b511..f2e7f25fda4a9be628c91f499f4322499184b921 100755
--- a/tools/isolate/isolate_smoke_test.py
+++ b/tools/isolate/isolate_smoke_test.py
@@ -223,7 +223,8 @@ class Isolate(unittest.TestCase):
out = out[:out.index('')]
modes = [re.match(r'^ (\w+) .+', l) for l in out]
modes = tuple(m.group(1) for m in modes if m)
- self.assertEquals(EXPECTED_MODES, modes)
+ # noop doesn't do anything so no point in testing it.
+ self.assertEquals(sorted(EXPECTED_MODES + ('noop',)), sorted(modes))
def test_modes(self):
# This is a bit redundant but make sure all combinations are tested.
« no previous file with comments | « tools/isolate/isolate.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698