Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: tools/isolate/isolate.py

Issue 10261010: Add --mode=noop so progress can be made while the builders are being reconfigured (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | tools/isolate/isolate_smoke_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/isolate.py
diff --git a/tools/isolate/isolate.py b/tools/isolate/isolate.py
index 9605873fdb706aa65bface7281f0bf6000bafb2c..2c102c394aedd9afc8ca57d98d2887158c6b06ce 100755
--- a/tools/isolate/isolate.py
+++ b/tools/isolate/isolate.py
@@ -8,6 +8,7 @@
--result and exits.
hashtable Puts a manifest file and hard links each of the inputs into the
output directory.
+ noop Do nothing, used for transition purposes.
remap Stores all the inputs files in a directory without running the
executable.
run Recreates a tree with all the inputs files and run the executable
@@ -518,7 +519,7 @@ def main():
default_variables.append(('EXECUTABLE_SUFFIX', '.exe'))
else:
default_variables.append(('EXECUTABLE_SUFFIX', ''))
- valid_modes = get_valid_modes()
+ valid_modes = get_valid_modes() + ['noop']
parser = optparse.OptionParser(
usage='%prog [options] [.isolate file]',
description=sys.modules[__name__].__doc__)
@@ -563,6 +564,11 @@ def main():
logging.debug('%s' % sys.argv)
parser.error('Use only one argument which should be a .isolate file')
+ if options.mode == 'noop':
+ # This undocumented mode is to help transition since some builders do not
+ # have all the test data files checked out. Exit silently.
+ return 0
+
root_dir, infiles, data = process_options(
dict(options.variables), options.result, args[0], parser.error)
« no previous file with comments | « build/common.gypi ('k') | tools/isolate/isolate_smoke_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698