Make Omnibox HistoryURL Provider always aggressive.

Make Omnibox HistoryURL Provider always aggressive.

Remove the code for the aggressive HistoryURL provider field trial and make the HistoryURL provider aggressive for everyone.  Also remove the single about flag that allowed users to force a particular behavior.  (Pretty much no one did.)

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134839

[Peter Kasting, 2012-04-30 21:44:58]

Yeah, let's go ahead and just remove them.  If we want to revert this behavior
on the branch it's not hard to revert this change, or some similar solution.

LGTM

[Mark P, 2012-04-30 22:18:45]

On 2012/04/30 21:44:58, Peter Kasting wrote:
> Yeah, let's go ahead and just remove them.  If we want to revert this behavior
> on the branch it's not hard to revert this change, or some similar solution.

Remove the aggressive scoring within history_url as requested.  Very easy.  Take
another look if you feel so inclined.


> 
> LGTM

[Mark P, 2012-05-01 19:48:00]

Just realized I forgot to update the unit test.  Now have done so.

Please take another look.

thanks,
mark


On 2012/04/30 22:18:45, Mark P wrote:
> On 2012/04/30 21:44:58, Peter Kasting wrote:
> > Yeah, let's go ahead and just remove them.  If we want to revert this
behavior
> > on the branch it's not hard to revert this change, or some similar solution.
> 
> Remove the aggressive scoring within history_url as requested.  Very easy. 
Take
> another look if you feel so inclined.
> 
> 
> > 
> > LGTM

[Peter Kasting, 2012-05-01 20:05:35]

http://codereview.chromium.org/10260020/diff/8002/chrome/browser/autocomplete...
File chrome/browser/autocomplete/history_url_provider_unittest.cc (right):

http://codereview.chromium.org/10260020/diff/8002/chrome/browser/autocomplete...
chrome/browser/autocomplete/history_url_provider_unittest.cc:565:
EXPECT_GT(1210, matches_[0].relevance);
This can't possibly be right.  One score can't be both less than 1200 and
greater than 1210.

Same problem in many places below.

[Mark P, 2012-05-01 20:41:26]

http://codereview.chromium.org/10260020/diff/8002/chrome/browser/autocomplete...
File chrome/browser/autocomplete/history_url_provider_unittest.cc (right):

http://codereview.chromium.org/10260020/diff/8002/chrome/browser/autocomplete...
chrome/browser/autocomplete/history_url_provider_unittest.cc:565:
EXPECT_GT(1210, matches_[0].relevance);
On 2012/05/01 20:05:35, Peter Kasting wrote:
> This can't possibly be right.  One score can't be both less than 1200 and
> greater than 1210.
> 
> Same problem in many places below.

This is equivalent to
1200 <= matches_[0].relevance
and
1210 > matches_[0].relevance
.

[Peter Kasting, 2012-05-01 20:46:22]

On 2012/05/01 20:41:26, Mark P wrote:
>
http://codereview.chromium.org/10260020/diff/8002/chrome/browser/autocomplete...
> File chrome/browser/autocomplete/history_url_provider_unittest.cc (right):
> 
>
http://codereview.chromium.org/10260020/diff/8002/chrome/browser/autocomplete...
> chrome/browser/autocomplete/history_url_provider_unittest.cc:565:
> EXPECT_GT(1210, matches_[0].relevance);
> On 2012/05/01 20:05:35, Peter Kasting wrote:
> > This can't possibly be right.  One score can't be both less than 1200 and
> > greater than 1210.
> > 
> > Same problem in many places below.
> 
> This is equivalent to
> 1200 <= matches_[0].relevance
> and
> 1210 > matches_[0].relevance
> .

Oh argh.  Don't do that.  We use (EXPECTED, ACTUAL) for "equal" and "not equal",
but for any other inequality, write it like you'd write the actual comparison:

EXPECT_LT(matches_[0].relevance, 1210);

LGTM rubber-stamp with that fixed; I don't actually know if the "window 10 wide"
comparison method is a good idea but I haven't thought about this at all.

[Mark P, 2012-05-01 21:26:16]

On 2012/05/01 20:46:22, Peter Kasting wrote:
> On 2012/05/01 20:41:26, Mark P wrote:
> >
>
http://codereview.chromium.org/10260020/diff/8002/chrome/browser/autocomplete...
> > File chrome/browser/autocomplete/history_url_provider_unittest.cc (right):
> > 
> >
>
http://codereview.chromium.org/10260020/diff/8002/chrome/browser/autocomplete...
> > chrome/browser/autocomplete/history_url_provider_unittest.cc:565:
> > EXPECT_GT(1210, matches_[0].relevance);
> > On 2012/05/01 20:05:35, Peter Kasting wrote:
> > > This can't possibly be right.  One score can't be both less than 1200 and
> > > greater than 1210.
> > > 
> > > Same problem in many places below.
> > 
> > This is equivalent to
> > 1200 <= matches_[0].relevance
> > and
> > 1210 > matches_[0].relevance
> > .
> 
> Oh argh.  Don't do that.  We use (EXPECTED, ACTUAL) for "equal" and "not
equal",
> but for any other inequality, write it like you'd write the actual comparison:
> 
> EXPECT_LT(matches_[0].relevance, 1210);
> 
> LGTM rubber-stamp with that fixed;

Fixed.

-m


> I don't actually know if the "window 10 wide"
> comparison method is a good idea but I haven't thought about this at all.

[commit-bot: I haz the power, 2012-05-01 22:12:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/10260020/12001

[commit-bot: I haz the power, 2012-05-02 00:58:16]

Change committed as 134839