Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: chrome/browser/autocomplete/history_url_provider.h

Issue 10260020: Make Omnibox HistoryURL Provider always aggressive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reordered EXPECT_GT to EXPECT_LT. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_url_provider.h
diff --git a/chrome/browser/autocomplete/history_url_provider.h b/chrome/browser/autocomplete/history_url_provider.h
index c7a1a4f1a61863f8b9e7e01a8d286bb9cfc6a7bb..241a47af1ed6c88b6d67ed880cfd94b3540db686 100644
--- a/chrome/browser/autocomplete/history_url_provider.h
+++ b/chrome/browser/autocomplete/history_url_provider.h
@@ -146,7 +146,6 @@ class HistoryURLProvider : public HistoryProvider {
: HistoryProvider(listener, profile, "History"),
prefixes_(GetPrefixes()),
params_(NULL),
- enable_aggressive_scoring_(false),
languages_(languages) {}
#endif
@@ -188,13 +187,13 @@ class HistoryURLProvider : public HistoryProvider {
// Returns the set of prefixes to use for prefixes_.
static history::Prefixes GetPrefixes();
- // Determines the relevance for a match, given its type. Behavior
- // depends on enable_aggressive_scoring_. If |match_type| is
- // NORMAL, |match_number| is a number [0, kMaxSuggestions)
- // indicating the relevance of the match (higher == more relevant).
- // For other values of |match_type|, |match_number| is ignored.
- // Only called some of the time; for some matches, relevancy scores
- // are assigned consecutively decreasing (1416, 1415, 1414, ...).
+ // Determines the relevance for a match, given its type. If
+ // |match_type| is NORMAL, |match_number| is a number [0,
+ // kMaxSuggestions) indicating the relevance of the match (higher ==
+ // more relevant). For other values of |match_type|, |match_number|
+ // is ignored. Only called some of the time; for some matches,
+ // relevancy scores are assigned consecutively decreasing (1416,
+ // 1415, 1414, ...).
int CalculateRelevance(MatchType match_type,
size_t match_number) const;
@@ -282,10 +281,6 @@ class HistoryURLProvider : public HistoryProvider {
// keep this member is so we can set the cancel bit on it.
HistoryURLProviderParams* params_;
- // Command line flag omnibox-aggressive-with-history-urls.
- // We examine and cache the value in the constructor.
- bool enable_aggressive_scoring_;
-
// Only used by unittests; if non-empty, overrides accept-languages in the
// profile's pref system.
std::string languages_;
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_field_trial.cc ('k') | chrome/browser/autocomplete/history_url_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698