Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 10258007: Make so in metro mode popups are background tabs (Closed)

Created:
8 years, 8 months ago by cpu_(ooo_6.6-7.5)
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Make so in metro mode popups are background tabs BUG=118641 TEST=see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134419

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
cpu_(ooo_6.6-7.5)
8 years, 8 months ago (2012-04-27 23:09:35 UTC) #1
sky
8 years, 8 months ago (2012-04-27 23:34:53 UTC) #2
LGTM

http://codereview.chromium.org/10258007/diff/4001/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_view.cc (right):

http://codereview.chromium.org/10258007/diff/4001/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.cc:1313: return
(base::win::GetMetroModule() == NULL) ? NEW_POPUP : NEW_BACKGROUND_TAB;
Add a comment as to why we're doing this.

Powered by Google App Engine
This is Rietveld 408576698