chrome/browser/ui/views/frame/browser_view.cc - Issue 10258007: Make so in metro mode popups are background tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 10258007: Make so in metro mode popups are background tabs (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

===================================================================

--- chrome/browser/ui/views/frame/browser_view.cc (revision 134390)

+++ chrome/browser/ui/views/frame/browser_view.cc (working copy)

@@ -1309,6 +1309,9 @@

GetWidget()->GetNativeView()).size();

return browser::DispositionForPopupBounds(

bounds, window_size.width(), window_size.height());

+#elif defined(OS_WIN)

+ // If we are in windows metro-mode, we can't allow popup windows.

+ return (base::win::GetMetroModule() == NULL) ? NEW_POPUP : NEW_BACKGROUND_TAB;

#else

return NEW_POPUP;

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »