Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 10253018: Disables a test to get the Android FYI bot green (Closed)

Created:
8 years, 8 months ago by gone
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Disables a test to get the Android FYI bot green Disables FileUtilProxyTest.Touch; it doesn't seem to have ever worked for Android and is keeping the bot red. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/android/gtest_filter/base_unittests_disabled View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
gone
8 years, 8 months ago (2012-04-27 22:07:32 UTC) #1
Yaron
lgtm but not a committer yet so you need a stamp from Jay or John.
8 years, 8 months ago (2012-04-27 22:40:40 UTC) #2
John Grabowski
LGTM Thx Dan
8 years, 8 months ago (2012-04-27 22:48:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/10253018/1
8 years, 8 months ago (2012-04-27 22:50:15 UTC) #4
commit-bot: I haz the power
Change committed as 134411
8 years, 8 months ago (2012-04-28 00:43:23 UTC) #5
gone
FYI: this was failing consistently after it was added in: http://src.chromium.org/viewvc/chrome?view=rev&revision=133484 http://codereview.chromium.org/10095028 Not sure if ...
8 years, 7 months ago (2012-05-08 00:21:36 UTC) #6
kinuko
On 2012/05/08 00:21:36, dfalcantara wrote: > FYI: this was failing consistently after it was added ...
8 years, 7 months ago (2012-05-08 03:19:34 UTC) #7
gone
8 years, 7 months ago (2012-05-08 04:09:26 UTC) #8
Thanks for looking into it; I didn't get a chance to file a bug because I've
been out of town.  I mainly added the info here to keep track of it while I
figured out where to file the bug under.

Powered by Google App Engine
This is Rietveld 408576698