Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 10095028: Convert MessageLoopProxy to TaskRunner in FileUtilProxy (Closed)

Created:
8 years, 8 months ago by kinuko
Modified:
8 years, 8 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Convert MessageLoopProxy to TaskRunner in FileUtilProxy Also adding unittests to FileUtilProxy. BUG=123558, 77454 TEST=FileUtilProxyTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133484

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+469 lines, -61 lines) Patch
M base/base.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/file_util_proxy.h View 8 chunks +18 lines, -18 lines 0 comments Download
M base/file_util_proxy.cc View 21 chunks +43 lines, -43 lines 0 comments Download
A base/file_util_proxy_unittest.cc View 1 1 chunk +407 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
8 years, 8 months ago (2012-04-19 10:47:11 UTC) #1
willchan no longer on Chromium
http://codereview.chromium.org/10095028/diff/1/base/file_util_proxy_unittest.cc File base/file_util_proxy_unittest.cc (right): http://codereview.chromium.org/10095028/diff/1/base/file_util_proxy_unittest.cc#newcode8 base/file_util_proxy_unittest.cc:8: #include "base/file_util_proxy.h" This should go above <map> according to ...
8 years, 8 months ago (2012-04-21 06:58:39 UTC) #2
kinuko
http://codereview.chromium.org/10095028/diff/1/base/file_util_proxy_unittest.cc File base/file_util_proxy_unittest.cc (right): http://codereview.chromium.org/10095028/diff/1/base/file_util_proxy_unittest.cc#newcode8 base/file_util_proxy_unittest.cc:8: #include "base/file_util_proxy.h" On 2012/04/21 06:58:39, willchan wrote: > This ...
8 years, 8 months ago (2012-04-23 09:01:33 UTC) #3
willchan no longer on Chromium
lgtm
8 years, 8 months ago (2012-04-23 14:22:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/10095028/9001
8 years, 8 months ago (2012-04-23 16:33:38 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 18:41:19 UTC) #6
Change committed as 133484

Powered by Google App Engine
This is Rietveld 408576698