Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: media/base/filters.cc

Issue 10248002: Report VideoDecoder status through ReadCB instead of through FilterHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revised on comments. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/filters.h ('k') | media/filters/ffmpeg_video_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/filters.cc
diff --git a/media/base/filters.cc b/media/base/filters.cc
index 910f1e7b8a437b2acd5c11ee438f41bcbf8892c1..7c6fabe943d3f155def8dd0d613162d0c8483761 100644
--- a/media/base/filters.cc
+++ b/media/base/filters.cc
@@ -74,6 +74,11 @@ void VideoDecoder::Seek(base::TimeDelta /* time */,
LOG(FATAL) << "VideoDecoder::Seek is not supposed to be called.";
}
+FilterHost* VideoDecoder::host(){
+ LOG(FATAL) << "VideoDecoder::host is not supposed to be called.";
scherkus (not reviewing) 2012/04/27 23:28:33 add TODO w/ crbug entry pointing at removing Filte
xhwang 2012/04/27 23:32:25 TODO is in filter.h together with Pause()/Seek()..
+ return NULL;
Ami GONE FROM CHROMIUM 2012/04/27 23:32:05 I'm surprised this is necessary (since LOG(FATAL)
+}
+
bool VideoDecoder::HasAlpha() const {
return false;
}
« no previous file with comments | « media/base/filters.h ('k') | media/filters/ffmpeg_video_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698