Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: media/base/filters.cc

Issue 10248002: Report VideoDecoder status through ReadCB instead of through FilterHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revised on comments. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « media/base/filters.h ('k') | media/filters/ffmpeg_video_decoder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/filters.h" 5 #include "media/base/filters.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace media { 9 namespace media {
10 10
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 67
68 void VideoDecoder::Pause(const base::Closure& /* callback */) { 68 void VideoDecoder::Pause(const base::Closure& /* callback */) {
69 LOG(FATAL) << "VideoDecoder::Pause is not supposed to be called."; 69 LOG(FATAL) << "VideoDecoder::Pause is not supposed to be called.";
70 } 70 }
71 71
72 void VideoDecoder::Seek(base::TimeDelta /* time */, 72 void VideoDecoder::Seek(base::TimeDelta /* time */,
73 const PipelineStatusCB& /* callback */) { 73 const PipelineStatusCB& /* callback */) {
74 LOG(FATAL) << "VideoDecoder::Seek is not supposed to be called."; 74 LOG(FATAL) << "VideoDecoder::Seek is not supposed to be called.";
75 } 75 }
76 76
77 FilterHost* VideoDecoder::host(){
78 LOG(FATAL) << "VideoDecoder::host is not supposed to be called.";
scherkus (not reviewing) 2012/04/27 23:28:33 add TODO w/ crbug entry pointing at removing Filte
xhwang 2012/04/27 23:32:25 TODO is in filter.h together with Pause()/Seek()..
79 return NULL;
Ami GONE FROM CHROMIUM 2012/04/27 23:32:05 I'm surprised this is necessary (since LOG(FATAL)
80 }
81
77 bool VideoDecoder::HasAlpha() const { 82 bool VideoDecoder::HasAlpha() const {
78 return false; 83 return false;
79 } 84 }
80 85
81 void VideoDecoder::PrepareForShutdownHack() {} 86 void VideoDecoder::PrepareForShutdownHack() {}
82 87
83 } // namespace media 88 } // namespace media
OLDNEW
« no previous file with comments | « media/base/filters.h ('k') | media/filters/ffmpeg_video_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698