Issue 10238016: convert history page to loadTimeData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10238016: convert history page to loadTimeData (Closed)

Created:
8 years, 8 months ago by Evan Stade

Modified:
8 years, 7 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, Patrick Dubroy, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

convert history page to loadTimeData BUG=122753 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134577

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -18 lines)			Patch
M	chrome/browser/resources/history/history.html	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/history/history.js	View	9 chunks	+8 lines, -10 lines	1 comment	Download
M	chrome/browser/ui/webui/history_ui.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

lgtm https://chromiumcodereview.appspot.com/10238016/diff/1/chrome/browser/resources/history/history.js File chrome/browser/resources/history/history.js (right): https://chromiumcodereview.appspot.com/10238016/diff/1/chrome/browser/resources/history/history.js#newcode38 chrome/browser/resources/history/history.js:38: // or just make the classes own more ...

8 years, 7 months ago (2012-04-30 17:11:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10238016/1

8 years, 7 months ago (2012-04-30 18:22:03 UTC) #3

Change committed as 134577

Expand Messages | Collapse Messages