Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/browser/resources/history/history.js

Issue 10238016: convert history page to loadTimeData (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/history/history.html ('k') | chrome/browser/ui/webui/history_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/history/history.js
diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js
index cf6eb091bbf58894ea115709446c4b1ae5c3c6f9..fcdd421bbe4be516028c9a765be8fd22b8c0c3e8 100644
--- a/chrome/browser/resources/history/history.js
+++ b/chrome/browser/resources/history/history.js
@@ -38,7 +38,6 @@ function findAncestorWithClass(node, className) {
// or just make the classes own more of the page.
Dan Beam 2012/04/30 17:11:30 this probably shouldn't be indented, but it's also
var historyModel;
var historyView;
-var localStrings;
var pageState;
var deleteQueue = [];
var selectionAnchor = -1;
@@ -124,7 +123,7 @@ Page.prototype.getResultDOM = function(searchResultFlag) {
var dropDown = createElementWithClassName('button', 'drop-down');
dropDown.value = 'Open action menu';
- dropDown.title = localStrings.getString('actionMenuDescription');
+ dropDown.title = loadTimeData.getString('actionMenuDescription');
dropDown.setAttribute('menu', '#action-menu');
cr.ui.decorate(dropDown, MenuButton);
@@ -686,7 +685,7 @@ HistoryView.prototype.displayResults_ = function() {
// Add a header for the search results, if there isn't already one.
if (!this.resultDiv_.querySelector('h3')) {
var header = document.createElement('h3');
- header.textContent = localStrings.getStringF('searchresultsfor',
+ header.textContent = loadTimeData.getStringF('searchresultsfor',
searchText);
this.resultDiv_.appendChild(header);
}
@@ -716,7 +715,7 @@ HistoryView.prototype.displayResults_ = function() {
day.appendChild(document.createTextNode(page.dateRelativeDay));
if (i == 0 && page.continued) {
day.appendChild(document.createTextNode(' ' +
- localStrings.getString('cont')));
+ loadTimeData.getString('cont')));
}
// If there is an existing dayResults element, append it.
@@ -756,10 +755,10 @@ HistoryView.prototype.displayNavBar_ = function() {
if (this.pageIndex_ > 0) {
this.pageDiv_.appendChild(
- this.createPageNav_(0, localStrings.getString('newest')));
+ this.createPageNav_(0, loadTimeData.getString('newest')));
this.pageDiv_.appendChild(
this.createPageNav_(this.pageIndex_ - 1,
- localStrings.getString('newer')));
+ loadTimeData.getString('newer')));
}
// TODO(feldstein): this causes the navbar to not show up when your first
@@ -767,7 +766,7 @@ HistoryView.prototype.displayNavBar_ = function() {
if (this.model_.getSize() > (this.pageIndex_ + 1) * RESULTS_PER_PAGE) {
this.pageDiv_.appendChild(
this.createPageNav_(this.pageIndex_ + 1,
- localStrings.getString('older')));
+ loadTimeData.getString('older')));
}
};
@@ -927,7 +926,6 @@ function load() {
var searchField = $('search-field');
searchField.focus();
- localStrings = new LocalStrings();
historyModel = new HistoryModel();
historyView = new HistoryView(historyModel);
pageState = new PageState(historyModel, historyView);
@@ -950,7 +948,7 @@ function load() {
activePage = null;
});
- var title = localStrings.getString('title');
+ var title = loadTimeData.getString('title');
uber.invokeMethodOnParent('setTitle', {title: title});
window.addEventListener('message', function(e) {
@@ -1051,7 +1049,7 @@ function removeItems() {
if (urls.length > 0) {
queue.push([date, urls]);
}
- if (checked.length > 0 && confirm(localStrings.getString('deletewarning'))) {
+ if (checked.length > 0 && confirm(loadTimeData.getString('deletewarning'))) {
for (var i = 0; i < queue.length; i++) {
// Reload the page when the final entry has been deleted.
var callback = i == 0 ? reloadHistory : null;
« no previous file with comments | « chrome/browser/resources/history/history.html ('k') | chrome/browser/ui/webui/history_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698